fix: Page JSON parsing and integration tests (#546)

twilio · Mar 13, 2020 · d073d8c · d073d8c
1 parent ef0d339
commit d073d8c
Show file tree

Hide file tree

Showing 330 changed files with 5,037 additions and 5,037 deletions.
diff --git a/lib/base/Page.js b/lib/base/Page.js
@@ -156,7 +156,7 @@ Page.prototype.processResponse = function(response) {
     throw new RestException(response);
   }
 
-  return JSON.parse(response.body);
+  return response.body;
 };
 
 /**

diff --git a/spec/integration/rest/accounts/v1/credential/aws.spec.js b/spec/integration/rest/accounts/v1/credential/aws.spec.js
@@ -31,7 +31,7 @@ describe('Aws', function() {
   });
   it('should treat the first each arg as a callback',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -51,15 +51,15 @@ describe('Aws', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/AWS?PageSize=50&Page=0'
           }
-      });
+      };
       holodeck.mock(new Response(200, body));
       client.accounts.v1.credentials
                         .aws.each(() => done());
     }
   );
   it('should treat the second arg as a callback',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -79,7 +79,7 @@ describe('Aws', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/AWS?PageSize=50&Page=0'
           }
-      });
+      };
       holodeck.mock(new Response(200, body));
       client.accounts.v1.credentials
                         .aws.each({pageSize: 20}, () => done());
@@ -92,7 +92,7 @@ describe('Aws', function() {
   );
   it('should find the callback in the opts object',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -112,15 +112,15 @@ describe('Aws', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/AWS?PageSize=50&Page=0'
           }
-      });
+      };
       holodeck.mock(new Response(200, body));
       client.accounts.v1.credentials
                         .aws.each({callback: () => done()}, () => fail('wrong callback!'));
     }
   );
   it('should generate valid list request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .aws.list();
@@ -141,7 +141,7 @@ describe('Aws', function() {
   );
   it('should generate valid read_empty response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [],
           'meta': {
               'first_page_url': 'https://accounts.twilio.com/v1/Credentials/AWS?PageSize=50&Page=0',
@@ -152,7 +152,7 @@ describe('Aws', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/AWS?PageSize=50&Page=0'
           }
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -168,7 +168,7 @@ describe('Aws', function() {
   );
   it('should generate valid read_full response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -188,7 +188,7 @@ describe('Aws', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/AWS?PageSize=50&Page=0'
           }
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -204,7 +204,7 @@ describe('Aws', function() {
   );
   it('should generate valid create request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var opts = {credentials: 'AKIAIOSFODNN7EXAMPLE:wJalrXUtnFEMI/K7MDENG/bPxRfiCYEXAMPLEKEY'};
       var promise = client.accounts.v1.credentials
@@ -228,14 +228,14 @@ describe('Aws', function() {
   );
   it('should generate valid create response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'date_created': '2015-07-31T04:00:00Z',
           'date_updated': '2015-07-31T04:00:00Z',
           'friendly_name': 'friendly_name',
           'sid': 'CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'url': 'https://accounts.twilio.com/v1/Credentials/AWS/CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-      });
+      };
 
       holodeck.mock(new Response(201, body));
 
@@ -252,7 +252,7 @@ describe('Aws', function() {
   );
   it('should generate valid fetch request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .aws('CRXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX').fetch();
@@ -274,14 +274,14 @@ describe('Aws', function() {
   );
   it('should generate valid fetch response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'date_created': '2015-07-31T04:00:00Z',
           'date_updated': '2015-07-31T04:00:00Z',
           'friendly_name': 'friendly_name',
           'sid': 'CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'url': 'https://accounts.twilio.com/v1/Credentials/AWS/CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -297,7 +297,7 @@ describe('Aws', function() {
   );
   it('should generate valid update request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .aws('CRXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX').update();
@@ -319,14 +319,14 @@ describe('Aws', function() {
   );
   it('should generate valid update response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'date_created': '2015-07-31T04:00:00Z',
           'date_updated': '2015-07-31T04:00:00Z',
           'friendly_name': 'friendly_name',
           'sid': 'CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'url': 'https://accounts.twilio.com/v1/Credentials/AWS/CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -342,7 +342,7 @@ describe('Aws', function() {
   );
   it('should generate valid remove request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .aws('CRXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX').remove();
@@ -364,7 +364,7 @@ describe('Aws', function() {
   );
   it('should generate valid delete response',
     function(done) {
-      var body = JSON.stringify(null);
+      var body = null;
 
       holodeck.mock(new Response(204, body));
 

diff --git a/spec/integration/rest/accounts/v1/credential/publicKey.spec.js b/spec/integration/rest/accounts/v1/credential/publicKey.spec.js
@@ -31,7 +31,7 @@ describe('PublicKey', function() {
   });
   it('should treat the first each arg as a callback',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -51,15 +51,15 @@ describe('PublicKey', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys?PageSize=50&Page=0'
           }
-      });
+      };
       holodeck.mock(new Response(200, body));
       client.accounts.v1.credentials
                         .publicKey.each(() => done());
     }
   );
   it('should treat the second arg as a callback',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -79,7 +79,7 @@ describe('PublicKey', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys?PageSize=50&Page=0'
           }
-      });
+      };
       holodeck.mock(new Response(200, body));
       client.accounts.v1.credentials
                         .publicKey.each({pageSize: 20}, () => done());
@@ -92,7 +92,7 @@ describe('PublicKey', function() {
   );
   it('should find the callback in the opts object',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -112,15 +112,15 @@ describe('PublicKey', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys?PageSize=50&Page=0'
           }
-      });
+      };
       holodeck.mock(new Response(200, body));
       client.accounts.v1.credentials
                         .publicKey.each({callback: () => done()}, () => fail('wrong callback!'));
     }
   );
   it('should generate valid list request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .publicKey.list();
@@ -141,7 +141,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid read_empty response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [],
           'meta': {
               'first_page_url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys?PageSize=50&Page=0',
@@ -152,7 +152,7 @@ describe('PublicKey', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys?PageSize=50&Page=0'
           }
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -168,7 +168,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid read_full response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'credentials': [
               {
                   'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
@@ -188,7 +188,7 @@ describe('PublicKey', function() {
               'previous_page_url': null,
               'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys?PageSize=50&Page=0'
           }
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -204,7 +204,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid create request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var opts = {publicKey: 'publickey'};
       var promise = client.accounts.v1.credentials
@@ -228,14 +228,14 @@ describe('PublicKey', function() {
   );
   it('should generate valid create response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'date_created': '2015-07-31T04:00:00Z',
           'date_updated': '2015-07-31T04:00:00Z',
           'friendly_name': 'friendly_name',
           'sid': 'CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys/CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-      });
+      };
 
       holodeck.mock(new Response(201, body));
 
@@ -252,7 +252,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid fetch request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .publicKey('CRXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX').fetch();
@@ -274,14 +274,14 @@ describe('PublicKey', function() {
   );
   it('should generate valid fetch response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'date_created': '2015-07-31T04:00:00Z',
           'date_updated': '2015-07-31T04:00:00Z',
           'friendly_name': 'friendly_name',
           'sid': 'CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys/CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -297,7 +297,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid update request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .publicKey('CRXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX').update();
@@ -319,14 +319,14 @@ describe('PublicKey', function() {
   );
   it('should generate valid update response',
     function(done) {
-      var body = JSON.stringify({
+      var body = {
           'account_sid': 'ACaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'date_created': '2015-07-31T04:00:00Z',
           'date_updated': '2015-07-31T04:00:00Z',
           'friendly_name': 'friendly_name',
           'sid': 'CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa',
           'url': 'https://accounts.twilio.com/v1/Credentials/PublicKeys/CRaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa'
-      });
+      };
 
       holodeck.mock(new Response(200, body));
 
@@ -342,7 +342,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid remove request',
     function(done) {
-      holodeck.mock(new Response(500, '{}'));
+      holodeck.mock(new Response(500, {}));
 
       var promise = client.accounts.v1.credentials
                                       .publicKey('CRXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX').remove();
@@ -364,7 +364,7 @@ describe('PublicKey', function() {
   );
   it('should generate valid delete response',
     function(done) {
-      var body = JSON.stringify(null);
+      var body = null;
 
       holodeck.mock(new Response(204, body));
-Original file line number
+Diff line change
@@ Expand Up / @@ -156,7 +156,7 @@ Page.prototype.processResponse = function(response) { @@
         throw new RestException(response);
       }
-      return JSON.parse(response.body);
+      return response.body;
     };
     /**
@@ Expand Down @@