Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing model definitions for statistics #625

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jassent
Copy link

@jassent jassent commented Jul 29, 2022

Fixes

Resolves: #624

Fixes these statistics models:
Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkerStatisticsResource
Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkersCumulativeStatisticsResource
Twilio.Rest.Taskrouter.V1.Workspace.Worker.WorkersRealTimeStatisticsResource

The prior models are missing definitions for statistical subresources that cause deserialization to return empty/null. Other statistics models are impacted by this same issue. Suggest that developers check for other statistics definitions using object instead of a strongly typed object.

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added ran tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

@jassent jassent changed the title Added missing model definitions for statistics fix-Added missing model definitions for statistics Jul 29, 2022
@jassent jassent changed the title fix-Added missing model definitions for statistics fix:Added missing model definitions for statistics Jul 29, 2022
@jassent jassent changed the title fix:Added missing model definitions for statistics fix: Added missing model definitions for statistics Jul 29, 2022
@JenniferMah
Copy link
Contributor

The changes are to generated code so we'll have to make changes in the generator. We have this on our internal backlog (DI-2274)

@jassent
Copy link
Author

jassent commented Aug 3, 2022

The changes are to generated code so we'll have to make changes in the generator. We have this on our internal backlog (DI-2274)

Understood. Thank you for reviewing and the explanation. Up to you whether or not to close.

@childish-sambino childish-sambino added the status: waiting for feature feature will be implemented in the future label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: waiting for feature feature will be implemented in the future
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete model definition in WorkersRealTimeStatisticsResource causes deserialization to fail
4 participants