Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgraded cli-core version and skip healthcheck api #573

Merged
merged 7 commits into from
Jan 25, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cli-audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,18 +10,18 @@ jobs:
strategy:
fail-fast: false
matrix:
node-version: [18.x, 16.x, 14.x]
node-version: [18.x, 16.x]
steps:
- name: Checkout cli repo
uses: actions/checkout@v2
with:
fetch-depth: 0
- run: make install
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: make install
- name: Run audit check
run: npm audit --audit-level=moderate --production
# minimum vulnerability level that will cause the command to fail
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ clean:

install: githooks clean
rm -f package-lock.json
npm install --no-optional
npm install --omit=optional

test:
npm test
Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,15 +35,14 @@
"version": "oclif readme && git add README.md"
},
"dependencies": {
"@oclif/color": "^1.0.1",
"@oclif/core": "^1.16.0",
"@oclif/plugin-autocomplete": "^1.3.0",
"@oclif/plugin-plugins": "^2.1.0",
"@oclif/plugin-update": "^2.1.3",
"@oclif/plugin-version": "^1.1.1",
"@oclif/plugin-warn-if-update-available": "^2.0.2",
"@sendgrid/mail": "^8.0.0",
"@twilio/cli-core": "^7.0.0",
"@twilio/cli-core": "^7.19.1",
"chalk": "^4.1.2",
"file-type": "^16.5.4",
"hyperlinker": "1.0.0",
Expand Down
1 change: 1 addition & 0 deletions src/hooks/init/twilio-api.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class TwilioRestApiPlugin extends Plugin {
};

Object.keys(actionDefinition.domain.paths).forEach((pathName) => {
if (pathName === '/healthcheck') return;
const versionName = pathName.split('/')[1];
const shortVersion = versionName.replace(/v/g, '');

Expand Down
Loading