Have Zork use plugin installer to pull down zorkjs package #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #27 +/- ##
==========================================
+ Coverage 98.36% 98.36% +<.01%
==========================================
Files 22 21 -1
Lines 549 551 +2
==========================================
+ Hits 540 542 +2
Misses 9 9
Continue to review full report at Codecov.
|
src/commands/zork.js
Outdated
| @@ -23,9 +25,11 @@ class Zork extends BaseCommand { | |||
| this.logger.warn('Standby, loading the dungeon...'); | |||
|
|
|||
| try { | |||
| await this.exec('npm install --no-save zorkjs'); | |||
| this.plugins = this.plugins || new Plugins(this.config); | |||
| await this.plugins.install('zorkjs', { tag: 'latest', force: false }); | |||
There was a problem hiding this comment.
Got this the first time:
➜ rm -rf ~/.twilio/node_modules/zorkjs
➜ bin/run zork -l debug
[DEBUG] Config File: /Users/sharrison/.twilio/config.json
» Standby, loading the dungeon...
[DEBUG] {}
» I don't know the word "zork".
Works the second time, which is why I had to manually delete zorkjs.
There was a problem hiding this comment.
Ahh, same for me. Weird.
|
OK, try again @childish-sambino ... not sure why the plugin installer |
childish-sambino
approved these changes
Jun 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
N/A
Checklist
Contributing to Twilio
Short description of what this PR does:
If you have questions, please file a support ticket, or create a Github Issue in this repository.