Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support enum flags of varying case #17

Merged
merged 1 commit into from
May 2, 2019
Merged

Conversation

childish-sambino
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Short description of what this PR does:

  • Accept varying case command API options and display the lower-case options in the help
  • This is to support APIs that only accept a specific case, but don't call that out in their definition

If you have questions, please file a support ticket, or create a Github Issue in this repository.

@codecov
Copy link

codecov bot commented May 2, 2019

Codecov Report

Merging #17 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #17   +/-   ##
=======================================
  Coverage   97.01%   97.01%           
=======================================
  Files          20       20           
  Lines         503      503           
=======================================
  Hits          488      488           
  Misses         15       15
Impacted Files Coverage Δ
src/base-commands/twilio-api-command.js 92.04% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57dba71...581d8a0. Read the comment docs.

@childish-sambino childish-sambino merged commit 5e1d8be into master May 2, 2019
@childish-sambino childish-sambino deleted the enum-to-string branch May 2, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants