Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project region support #14

Merged
merged 1 commit into from
Apr 29, 2019
Merged

Add project region support #14

merged 1 commit into from
Apr 29, 2019

Conversation

childish-sambino
Copy link
Contributor

Fixes

Checklist

  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the [Contribution Guide] and my PR follows them.
  • I updated my branch with the master branch.
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation about the functionality in the appropriate .md file
  • I have added in line documentation to the code I modified

Contributing to Twilio

All third party contributors acknowledge that any contributions they provide will be made under the same open source license that the open source project is provided under.

Short description of what this PR does:

  • Adds a region flag to the project topic

If you have questions, please file a support ticket, or create a Github Issue in this repository.

@codecov
Copy link

codecov bot commented Apr 29, 2019

Codecov Report

Merging #14 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #14      +/-   ##
==========================================
+ Coverage      97%   97.01%   +0.01%     
==========================================
  Files          20       20              
  Lines         500      503       +3     
==========================================
+ Hits          485      488       +3     
  Misses         15       15
Impacted Files Coverage Δ
src/commands/project/list.js 100% <100%> (ø) ⬆️
src/commands/project/add.js 90.12% <100%> (+0.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b16a076...bddd923. Read the comment docs.

@@ -5,9 +5,14 @@ class ProjectList extends BaseCommand {
async run() {
await super.run();
if (this.userConfig.projects.length > 0) {
// If none of the projects have a region, delete it from all of them so it doesn't show up in the output.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch

@childish-sambino childish-sambino merged commit f15f227 into master Apr 29, 2019
@childish-sambino childish-sambino deleted the project-region branch April 29, 2019 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants