Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Throw alert when active profile is not set. #131

Merged
merged 1 commit into from
Jul 6, 2021
Merged

chore: Throw alert when active profile is not set. #131

merged 1 commit into from
Jul 6, 2021

Conversation

ravali-rimmalapudi
Copy link
Contributor

@ravali-rimmalapudi ravali-rimmalapudi commented Jul 6, 2021 •
edited
Loading

Fixes

Closes : DI-1479
Dependent PR: CLI,CLI-TEST

Changes in active profile: Throwing the error when active profile is NULL and no environment variable is set in case of any command that requires API keys.

Testing Gist : Link

Checklist

  • I acknowledge that all my contributions will be made under the project's license
  • I have made a material change to the repo (functionality, testing, spelling, grammar)
  • I have read the Contribution Guidelines and my PR follows them
  • I have titled the PR appropriately
  • I have updated my branch with the main branch
  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary documentation about the functionality in the appropriate .md file
  • I have added inline documentation to the code I modified

If you have questions, please file a support ticket, or create a GitHub Issue in this repository.

@ravali-rimmalapudi
Fetching profile by order if active profile is not set
bbdbb04 
1. Throwing the error when active profile is NULL and no environment variable is set in case of any command that requires API keys.
2. Added the corresponding test cases.
@ravali-rimmalapudi ravali-rimmalapudi changed the title chore: Fetching profile by order if active profile is not set chore: Throw alert when active profile is not set. Jul 6, 2021
This was referenced Jul 6, 2021
Merged
Merged
childish-sambino
childish-sambino approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@childish-sambino childish-sambino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

onuzbee
onuzbee approved these changes Jul 6, 2021
View reviewed changes
Copy link
Contributor

@onuzbee onuzbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@Sindhura3 Sindhura3 merged commit 65fc135 into release-feature-branch Jul 6, 2021
@Sindhura3 Sindhura3 deleted the DI-1479_active_profile branch July 6, 2021 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@onuzbee onuzbee onuzbee approved these changes

@childish-sambino childish-sambino childish-sambino approved these changes

@Sindhura3 Sindhura3 Awaiting requested review from Sindhura3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ravali-rimmalapudi @onuzbee @childish-sambino @Sindhura3