Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't create plugin: frame-ui package missing #2

Closed
rynop opened this issue Oct 18, 2018 · 8 comments
Closed

can't create plugin: frame-ui package missing #2

rynop opened this issue Oct 18, 2018 · 8 comments
Assignees
Labels
bug Something isn't working

Comments

@rynop
Copy link

rynop commented Oct 18, 2018

  1. create-flex-plugin plugin-sfdc --yarn
  2. cd plugin-sfdc
  3. yarn

Get the error:

yarn install v1.9.4
...
error Couldn't find package "@twilio/frame-ui@^0.16.0" required by "@twilio/flex-ui@^1.0.0" on the "npm" registry.
...

Is @twilio/frame-ui not public?

A little un-related - where on github can we see the source of the @twilio/* packages?

thanks

@rynop rynop changed the title frame-ui package missing can't create plugin: frame-ui package missing Oct 18, 2018
@dkundel
Copy link
Member

dkundel commented Oct 18, 2018

Hey @rynop,

thanks for filing the issue. We are on it and I'll let you know once we fixed it.

Both of those packages are not currently public on GitHub. You should be able to find all the necessary documentation on twilio.com/docs/flex and the team will continue improve the documentation going forward. Let me know if there is anything missing.

Cheers,
Dominik

@rynop
Copy link
Author

rynop commented Oct 18, 2018

@dkundel thanks!

I have a few documentation gaps. Should I file issues against this repo for these gaps?

@dkundel
Copy link
Member

dkundel commented Oct 18, 2018

Okay @rynop, it seems like yarn is not detecting the bundledDependencies entry in our package.json and tries to install it regardless. This works fine in npm though. The team will work on a fix for it but since we are all heads down with SIGNAL atm, I would recommend to try to use npm in the meantime until we found a fix.

For documentation gaps, feel free to file separate issues and label them as docs and we'll have the team work on them.

Sorry for the inconvenience!

@rynop
Copy link
Author

rynop commented Oct 18, 2018

10-4 on filing issues for docs.

npm install does not work:

cd plugin-sfdc/
~/p/f/plugin-sfdc (ga|✚2…) $ npm install
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! asyncWrite is not a function
npm ERR! pna.nextTick is not a functio

This stems from my initial problem that I was unable to install create-flex-plugin via npm:

npm install -g create-flex-plugin
npm ERR! asyncWrite is not a function
npm ERR! pna.nextTick is not a function

I worked around it by adding it as a devDependency and making a script and using yarn:

  "scripts": {
    "cfp": "create-flex-plugin"
  },

This let me do yarn cfp plugin-sfdc --yarn, however now I'm stuck (can't do npm install or yarn install).

Here are my versions:

node --version
v10.9.0
npm --version
6.2.0
yarn --version
1.9.4

FWIW using npm to get around roadblocks is fine, but ultimately yarn is a requirement for us.

Is there ever plans to open up/open source the @twillio/* packages? This way the community can help address issues / add features etc...

@dkundel
Copy link
Member

dkundel commented Oct 18, 2018

Do you happen to use n for you Node versioning? This seems to be a bug on their side: tj/n#510

We are working on yarn support. @madisabel is looking at a solution. This seems to be a known issue though: yarnpkg/yarn#5998

As for making the packages public I'll redirect you to @tmihnovits as I won't be able to give you any answers on this.

@rynop
Copy link
Author

rynop commented Oct 19, 2018

I use something similar - fnm. Thank you for reminding me. Removing fnm cache fixed the asyncWrite issue.

Thanks @madisabel for working the yarn issue

@tmihnovits looking forward to your thoughts on OSS w/r/t flex

@dkundel dkundel added the bug Something isn't working label Oct 25, 2018
@narendrashetty
Copy link
Contributor

narendrashetty commented Nov 21, 2018

As @dkundel mentioned, this is more of a bug from yarn side and it's not a huge priority for them to fix it as of now. https://twitter.com/arcanis/status/1065212411026771968

I suggest we use npm only for this project until we support yarn the right way. I will make a PR to update the docs.

@andreasonny83
Copy link
Contributor

Closing this one as related to #26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants