Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zendesk tickets side load objects #2

Merged
merged 10 commits into from
Jul 23, 2021
Merged

Conversation

guptaa3
Copy link
Collaborator

@guptaa3 guptaa3 commented Jul 15, 2021

Description of change

Adding the functionality to side load ticket objects
https://developer.zendesk.com/documentation/ticketing/using-the-zendesk-api/side_loading/#special-sideloads

  1. Added a new field "sideload-objects" that can be passed in the metadata of the catalog file as a list
  2. A variable "SIDELOAD_OBJECTS" added which has a list of all objects that can be side loaded to tickets (more can be added later)
  3. Method added to add the schema for these side loaded objects to stream.schema which will check if these objects are valid side load objects and add the schema if true
  4. Change added to fetch tickets call to include sideload objects

Manual QA steps

  • Tested by loading the side load objects
  • test table can be temporarily found here in public.raw_zendesk_tickets_test_sideload (internal to twilio)

Risks

Rollback steps

  • revert this branch

@guptaa3 guptaa3 changed the title Des 1610 2 Zendesk tickets side load objects Jul 22, 2021
Copy link
Contributor

@BenjMaq BenjMaq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Small request and small nits

tap_zendesk/__init__.py Outdated Show resolved Hide resolved
tap_zendesk/streams.py Show resolved Hide resolved
@guptaa3 guptaa3 merged commit dca1c3c into twilio-labs:master Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants