Use XDocument.Save
or XDocument.SaveAsync
to write to response body when possible
#112
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new
TwiML.ToXDocument()
method (PR) from the Twilio C# helper library, we can now avoid serializing the XML to a big string before writing it to the response body.ASP.NET Core does require writes to the response to be async, and in older .NET Core versions
XDocument.SaveAsync
is not available. In that case, the XML is serialized to a string and written to the response.For ASP.NET, there's only
XDocument.Save
available but there's no need for asynchronous writes.Additionally, I replaced null checks with
string.IsNullOrEmpty
forBaseUrlOverride
because sometimes the setting is an empty string.Contributing to Twilio