Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(model): guild member update includes deaf, mute #774

Merged
merged 3 commits into from
Apr 21, 2021

Conversation

7596ff
Copy link
Contributor

@7596ff 7596ff commented Apr 17, 2021

discord/discord-api-docs@fa9a073

Signed-off-by: Cassandra McCarthy [email protected]

@7596ff 7596ff added c-model Affects the model crate d-api Change related to Discord's API. enhancement labels Apr 17, 2021
@zeylahellyer zeylahellyer changed the title fix(model): guild member update includes deaf, mute feat(model): guild member update includes deaf, mute Apr 18, 2021
zeylahellyer
zeylahellyer previously approved these changes Apr 18, 2021
Copy link
Contributor

@james7132 james7132 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While it's probably not expected to be sent via GUILD_MEMBER_UPDATE gateway event, should the voice state of a member in the cache be updated if these fields are present?

@7596ff
Copy link
Contributor Author

7596ff commented Apr 18, 2021

You're right, I didn't catch that.

@7596ff 7596ff marked this pull request as draft April 18, 2021 23:14
Signed-off-by: Cassandra McCarthy <[email protected]>
@7596ff 7596ff marked this pull request as ready for review April 21, 2021 05:56
Signed-off-by: Cassandra McCarthy <[email protected]>
@zeylahellyer zeylahellyer merged commit 299492d into twilight-rs:trunk Apr 21, 2021
zeylahellyer added a commit that referenced this pull request Apr 27, 2021
Additions

Support the `MemberUpdate::{deaf, mute}` fields ([#774] - [@7596ff]).

Support guild stage channels, add `REQUEST_TO_SPEAK` permission
([#793] - [@james7132]).

Support the `USE_SLASH_COMMANDS` permission ([#794] - [@james7132]).

[@7596ff]: https://github.com/7596ff
[@james7132]: https://github.com/james7132
[#794]: #794
[#793]: #793
[#774]: #774

Signed-off-by: Vivian Hellyer <[email protected]>
zeylahellyer added a commit that referenced this pull request Apr 27, 2021
Additions

Support the `MemberUpdate::{deaf, mute}` fields ([#774] - [@7596ff]).

Support guild stage channels ([#793] - [@james7132]).

[@7596ff]: https://github.com/7596ff
[@james7132]: https://github.com/james7132
[#793]: #793
[#774]: #774

Signed-off-by: Vivian Hellyer <[email protected]>
@7596ff 7596ff deleted the docs-member-deaf-mute branch May 12, 2021 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c-model Affects the model crate d-api Change related to Discord's API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants