-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(model): guild member update includes deaf, mute #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
discord/discord-api-docs@fa9a073 Signed-off-by: Cassandra McCarthy <[email protected]>
7596ff
added
c-model
Affects the model crate
d-api
Change related to Discord's API.
enhancement
labels
Apr 17, 2021
zeylahellyer
changed the title
fix(model): guild member update includes deaf, mute
feat(model): guild member update includes deaf, mute
Apr 18, 2021
zeylahellyer
previously approved these changes
Apr 18, 2021
james7132
reviewed
Apr 18, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While it's probably not expected to be sent via GUILD_MEMBER_UPDATE gateway event, should the voice state of a member in the cache be updated if these fields are present?
You're right, I didn't catch that. |
Signed-off-by: Cassandra McCarthy <[email protected]>
Signed-off-by: Cassandra McCarthy <[email protected]>
tbnritzdoge
approved these changes
Apr 21, 2021
zeylahellyer
approved these changes
Apr 21, 2021
zeylahellyer
added a commit
that referenced
this pull request
Apr 27, 2021
Additions Support the `MemberUpdate::{deaf, mute}` fields ([#774] - [@7596ff]). Support guild stage channels, add `REQUEST_TO_SPEAK` permission ([#793] - [@james7132]). Support the `USE_SLASH_COMMANDS` permission ([#794] - [@james7132]). [@7596ff]: https://github.com/7596ff [@james7132]: https://github.com/james7132 [#794]: #794 [#793]: #793 [#774]: #774 Signed-off-by: Vivian Hellyer <[email protected]>
zeylahellyer
added a commit
that referenced
this pull request
Apr 27, 2021
Additions Support the `MemberUpdate::{deaf, mute}` fields ([#774] - [@7596ff]). Support guild stage channels ([#793] - [@james7132]). [@7596ff]: https://github.com/7596ff [@james7132]: https://github.com/james7132 [#793]: #793 [#774]: #774 Signed-off-by: Vivian Hellyer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
discord/discord-api-docs@fa9a073
Signed-off-by: Cassandra McCarthy [email protected]