refactor(model): simplify activity button text (de)serialization #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Simplify the (de)serialization of `gateway::presence::activity_button::ActivityButtonText`. We can remove the custom Deserialize and Serialize implementations by taking advantage of the fact that it has only one field, and instead using `#[serde(transparent)]`. Part of #1364.
github-actions
bot
added
c-model
6 tasks
7596ff
approved these changes
Jan 27, 2023
Erk-
approved these changes
Jan 28, 2023
zeylahellyer
deleted the
zeyla/refactor-model-activity-button-text-serde
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify the (de)serialization of
gateway::presence::activity_button::ActivityButtonText. We can remove the custom Deserialize and Serialize implementations by taking advantage of the fact that it has only one field, and instead using#[serde(transparent)].Part of #1364.