Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(http,model,util,validate)!: use Cow<'a, [u8]> for attachments #1923

Open
wants to merge 3 commits into
base: old-next
Choose a base branch
from
Open

feat(http,model,util,validate)!: use Cow<'a, [u8]> for attachments #1923

wants to merge 3 commits into from

Commits on Sep 17, 2022

  1. feat(http,model,util,validate)!: use Cow<'a, [u8]> for attachments 

    Instead of taking `&'a [u8]` for attachments, which could cause lifetime
issues when using functions like `fn create_attachment<'a>() -> Attachment<'a>`, `Cow<'a, u8>` can be used to support both creating attachments from owned and borrowed bytes.

This is a followup idea to: #1886
    @itohatweb
    itohatweb committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    2560700 View commit details
    Browse the repository at this point in the history

  2. fix docs

    @itohatweb
    itohatweb committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    a93eda3 View commit details
    Browse the repository at this point in the history

  3. fix wrong path

    @itohatweb
    itohatweb committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    5d23287 View commit details
    Browse the repository at this point in the history