fix(model): thread sync has channel ids, not guild ids #1420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
c-model
itohatweb
approved these changes
Jan 3, 2022
HTGAzureX1212
approved these changes
Jan 3, 2022
vilgotf
approved these changes
Jan 3, 2022
Gelbpunkt
approved these changes
Jan 3, 2022
7596ff
added a commit
that referenced
this pull request
Jan 8, 2022
Additions
Add `{Guild, PartialGuild}::premium_progress_bar_enabled` ([#1399] -
[@Erk-]).
Support guild timeouts in `MemberUpdate` ([#1414] - [@AEnterprise]).
Add `VoiceState::self_video` ([#1422] - [@AEnterprise]).
Support guild timeouts in the audit log ([#1423] - [@itohatweb]).
Changes
`CallbackData::embeds` is now an `Option<Vec>` instead of a `Vec`
([#1401] - [@itohatweb]).
Fixes
Properly deserialize `AuditLogChange::{RoleAdd, RoleRemove}` as `$add`
and `$remove` ([#1419] - [@itohatweb]).
Change `ThreadListSync::channel_ids` to a list of channel IDs instead of
guild IDs ([#1420] - [@AEnterprise]).
Properly deserialize `ThreadDelete` ([#1426] - [@AEnterprise]).
[#1399]: #1399
[#1401]: #1401
[#1414]: #1414
[#1419]: #1419
[#1420]: #1420
[#1422]: #1422
[#1423]: #1423
[#1426]: #1426
[@AEnterprise]: https://github.com/AEnterprise
[@Erk-]: https://github.com/Erk-
[@itohatweb]: https://github.com/itohatweb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typing was wrong in this model. Technically a breaking change but targeted at main since it's an an incorrect mapping