Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement stage channels #746

Closed
3 tasks done
7596ff opened this issue Apr 1, 2021 · 3 comments · Fixed by #748, #793 or #795
Closed
3 tasks done

Implement stage channels #746

7596ff opened this issue Apr 1, 2021 · 3 comments · Fixed by #748, #793 or #795
Assignees
@james7132
Labels
c-http Affects the http crate c-model Affects the model crate d-api Change related to Discord's API. f-stage-instances Related to supporting the Stage Instances feature. t-feature Addition of a new feature

Comments

@7596ff
Copy link
Contributor

7596ff commented Apr 1, 2021 •
edited
Loading

API docs PR: discord/discord-api-docs#2751
@7596ff 7596ff added t-feature Addition of a new feature c-http Affects the http crate c-model Affects the model crate d-api Change related to Discord's API. labels Apr 1, 2021
This was referenced Apr 1, 2021
Closed
Merged
Noskcaj19 pushed a commit to terminal-discord/twilight that referenced this issue Apr 2, 2021
@zeylahellyer @Noskcaj19
feat(model/channel): support stage voice channels
b39f919 
Support guild stage voice channels. This is denoted by channel type 13.
This is, in effect, a voice channel, but with a separate channel type to
mark that it has additional external capability.

This is a part of twilight-rs#746.

Signed-off-by: Vivian Hellyer <[email protected]>
zeylahellyer added a commit that referenced this issue Apr 4, 2021
@zeylahellyer
feat(model/channel): support stage voice channels (#748)
ab9f835 
Support guild stage voice channels. This is denoted by channel type 13.
This is, in effect, a voice channel, but with a separate channel type to
mark that it has additional external capability.

This is a part of #746.

Approved-by: Cassandra McCarthy <[email protected]>
Merged-by: Vivian Hellyer <[email protected]>
Signed-off-by: Vivian Hellyer <[email protected]>
@zeylahellyer zeylahellyer mentioned this issue Apr 14, 2021
Open
@7596ff 7596ff self-assigned this Apr 17, 2021
@james7132 james7132 linked a pull request Apr 20, 2021 that will close this issue
Support stage voice channel type #748
Merged
@james7132
Copy link
Contributor

Implemented via #748.

@zeylahellyer
Copy link
Member

#748 was only for the channel type, other features around stage channels like the HTTP requests need to be done still.

@zeylahellyer zeylahellyer reopened this Apr 20, 2021
@zeylahellyer zeylahellyer assigned james7132 and unassigned 7596ff Apr 21, 2021
@james7132 james7132 linked a pull request Apr 22, 2021 that will close this issue
models: Implement stage channels #793
Merged
@7596ff 7596ff linked a pull request Apr 22, 2021 that will close this issue
feat(http): support new routes related to stage channels #795
Merged
@zeylahellyer
Copy link
Member

This was erroneously closed again by #793 which only implemented the models. Re-opening since #795 remains. I've added a checklist of sub-tasks for this issue in the OP.

@zeylahellyer zeylahellyer reopened this Apr 22, 2021
@zeylahellyer zeylahellyer added the f-stage-instances Related to supporting the Stage Instances feature. label May 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@james7132 james7132

Labels
c-http Affects the http crate c-model Affects the model crate d-api Change related to Discord's API. f-stage-instances Related to supporting the Stage Instances feature. t-feature Addition of a new feature
Projects
None yet
Milestone
No milestone
3 participants
@7596ff @james7132 @zeylahellyer