Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove TemplateWrapper::render() 2nd parameter not used #3886

Merged
merged 1 commit into from
Oct 20, 2023

Conversation

GromNaN
Copy link
Contributor

@GromNaN GromNaN commented Oct 8, 2023

The 2nd virtual parameter of TemplateWrapper::render() was added by #2805.
Template::render() don't define and don't use this 2nd parameter.

Running the test suite, this method never get more than 1 parameter (I assumed it could be used by the compiled Template via the backtrace, but it isn't).

@fabpot
Copy link
Contributor

fabpot commented Oct 20, 2023

Thank you @GromNaN.

@fabpot fabpot merged commit 78e5245 into twigphp:3.x Oct 20, 2023
57 checks passed
@GromNaN GromNaN deleted the render-2nd-arg branch October 20, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants