Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to namespaces (2.x) #2863

Merged
merged 9 commits into from
Mar 5, 2019
Merged

Conversation

fabpot
Copy link
Contributor

@fabpot fabpot commented Mar 5, 2019

No description provided.

fabpot added 9 commits March 4, 2019 20:21
This PR was squashed before being merged into the 1.x branch (closes twigphp#2862).

Discussion
----------

Switch to namespaces

Commits
-------

baa7028 switched to namespace first, PSR-0 as a fallback
aae29ce fixed tests for errors
* 1.x:
  switched to namespace first, PSR-0 as a fallback
  fixed tests for errors
@fabpot fabpot merged commit 037ee67 into twigphp:2.x Mar 5, 2019
@fabpot fabpot deleted the switch-to-namespaces-2x branch March 5, 2019 07:38
chalasr added a commit to manala/manalize that referenced this pull request Mar 13, 2019
This PR was squashed before being merged into the master branch (closes #163).

Discussion
----------

chore: fix Twig deprecations in tests

Not an insane PR, but this should fix Twig deprecations in tests:
![Sélection_396](https://user-images.githubusercontent.com/2103975/54280328-7cf01d80-4597-11e9-8ae7-3082048e2ce9.png)

Recently in Twig, class aliases (`\Twig_Environment`) have been deprecated for class namespaces (`\Twig\Environment`), refs:
  - https://symfony.com/blog/new-in-twig-namespaced-classes
  - twigphp/Twig#2863
  - twigphp/Twig#2869
  - [changelog](https://github.com/twigphp/Twig/blob/2fe2f2d8bba055f78657b81d01ed588fd22d8cd3/CHANGELOG#L23)

Commits
-------

23ca55f chore: fix Twig deprecations in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant