-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feature #4479 Simplify EscaperNodeVisitor code (fabpot)
This PR was merged into the 3.x branch. Discussion ---------- Simplify EscaperNodeVisitor code This PR simplifies how we escape the ternary operator, and simplifies the whole strategy. Instead of replacing the `PrintNode`s, we instead "just" wrap the inner expressions. For the ternary operator, the `InlinePrint` expression is useless and even weird as printing something in the middle of an expression looks very wrong. This is not done anymore and the node is deprecated. Overall, this PR makes fewer changes to the Node tree which should make things use a bit less memory. Commits ------- 02cec77 Simplify EscaperNodeVisitor code
- Loading branch information
Showing
4 changed files
with
15 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters