Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented batch filter #161

Merged
merged 2 commits into from
Jun 10, 2014
Merged

Implemented batch filter #161

merged 2 commits into from
Jun 10, 2014

Conversation

jmealo
Copy link
Contributor

@jmealo jmealo commented Jun 8, 2014

This PR implements the batch filter and some basic tests.

This is my first PR against Twig.js, let me know if it's missing anything.

I put chunkArray in Twig.lib, however, it could be a nested function inside of batch if you prefer. I checked Twig and array_chunk is only used twice in the library including it's use in the batch filter.

@jmealo
Copy link
Contributor Author

jmealo commented Jun 8, 2014

Travis fails on Node.js 0.6 and 0.8 due to issues with NPM. All tests pass with this PR.

@justjohn justjohn merged commit bb2bc0e into twigjs:master Jun 10, 2014
justjohn added a commit that referenced this pull request Jun 10, 2014
@justjohn
Copy link
Collaborator

Your pull requests looks great, they have code and supporting tests. chunkArray is fine in Twig.lib, it's common enough functionality that there's no real reason for it to live in the filter.

Thanks for the contribution!

@jmealo
Copy link
Contributor Author

jmealo commented Jun 11, 2014

Thanks for the quick response.

Do you want the results of make comitted or just the files I changed? It
looks like you do a build following merges.

  • Jeff

On Tue, Jun 10, 2014 at 12:06 AM, John Roepke [email protected]
wrote:

Your pull requests looks great, they have code and supporting tests.
chunkArray is fine in Twig.lib, it's common enough functionality that
there's no real reason for it to live in the filter.

Thanks for the contribution!


Reply to this email directly or view it on GitHub
#161 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants