Add .A[] access for table view support in debug
#14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanc
approved these changes
Dec 4, 2024
| ) | ||
| table_view[:] = [2, 3, 4, 5] | ||
|
|
||
| @gtscript.stencil(backend="debug") |
There was a problem hiding this comment.
random thought: once we bring the debug backend back into gt4py mainline, we should check which tests are specific to the debug backend and which tests should actually be annotated with @gtscript.stencil(backend=ALL_BACKENDS (with potential excludes referencing issues with missing implementation in other backends)
There was a problem hiding this comment.
I'll log that in right away, I can feel myself forgetting
There was a problem hiding this comment.
FlorianDeconinck
approved these changes
Dec 4, 2024
| ) | ||
| table_view[:] = [2, 3, 4, 5] | ||
|
|
||
| @gtscript.stencil(backend="debug") |
There was a problem hiding this comment.
FlorianDeconinck
changed the title
.A[] access for table view support in debug.A[] access for table view support in debug
FlorianDeconinck
merged commit 8ed7a0d
into
int_cast_aboslute_k_debug
0 of 3 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the
GlobalTablefeature support fordebugbackend.Global table is an "off-grid" array that can only be accessed absolutely via data dimensions.