-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken Pre-commit #12
base: int_cast_aboslute_k_debug
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
A suggestion: Since we are on that debug branch of your fork for some time, it might be worth to have CI run on that branch to catch things like these before they happen.
Given that enabling all of CI is problematic with the fast-moving pace (and deliberate "let's not implement it in all the backends" decision), how about we only enable the "code quality" workflow? That way tests won't get in our way while we are sure that linting & formatting passes. For me, this would be a good compromise between dev speed on an unstable branch and enforced consistency through CI. |
I think this unearthed actual issues though. @twicki will look through first - and we might do a clever partial deactivation. We can log in GEOS-ESM/SMT-Nebulae#98 any "reactivation" needed before we start moving back all of those features in |
Description
Describe the content of the PR and links to related issues, bugs of features.
Requirements
Before submitting this PR, please make sure:
new features
Additionally, if this PR contains code authored by new contributors:
signed by the employer if needed, provided to ETH Zurich
version of the AUTHORS.rst file included in the PR