-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New 'vehicle connected' binary sensor, bug fix & deprecation resolution #18
base: master
Are you sure you want to change the base?
Conversation
…solve deprecation warning)
…et' (Unsupported in HA)
The unit tests pass locally for me;
Would appreciate any pointers on how to get these passing in the project github 'pull' workflow. |
It looks like the python version in the pull workflow was outdated. Upgraded that + home assistant and now the tests all pass in the github pipeline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My only real concern is the duplicate bugfix, thank you for your effort, it looks great!
Hi!
This pull request adds a new entity, fixes a bug and resolves some deprecation warnings.
Im running this branch on my HA instance (2024.12.1), unit tests should be passing too. Happy to answer any questions or make changes from review