Merge pull request #1 from william00179/feature/expand-s3-configurati…

…on-options Expanded the S3 configuration options
tweedegolf · Aug 16, 2019 · 9b83f8e · 9b83f8e
2 parents cfa67d4 + 40c61af
commit 9b83f8e
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/StorageAmazonS3.ts b/src/StorageAmazonS3.ts
@@ -19,8 +19,7 @@ export class StorageAmazonS3 extends AbstractStorage implements IStorage {
       throw new Error('provide both an accessKeyId and a secretAccessKey!');
     }
     this.storage = new S3({
-      accessKeyId,
-      secretAccessKey,
+      ...config,
       apiVersion: '2006-03-01',
     });
     // console.log(config, this.bucketName);

diff --git a/src/types.ts b/src/types.ts
@@ -1,4 +1,5 @@
 import { Readable } from 'stream';
+import {bool} from 'aws-sdk/clients/signer';
 
 export interface IStorage {
   /**
@@ -76,6 +77,12 @@ export type ConfigAmazonS3 = {
   bucketName?: string,
   accessKeyId: string,
   secretAccessKey: string,
+  endpoint?: string,
+  useDualstack?: boolean,
+  region?: string,
+  maxRetries?: number,
+  maxRedirects?: number,
+  sslEnabled?: boolean,
 };
 
 export type ConfigGoogleCloud = {