Reinstate coverage tests #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nbacquey Should the base branch for this PR be |
nbacquey
force-pushed
the
nb/coverage_test
branch
from
16e21e0 to
4d64adc
Compare
nbacquey
force-pushed
the
nb/coverage_test
branch
from
4d64adc to
2f7fefe
Compare
Xophmeister
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reinstates coverage checks, that were discarded following #672. Those tests check that every piece of query in the
*.scmfiles matches something in the corresponding input file.In essence, they ensure that every query is useful.
Closes #674
Depends on #785
Checklist
Checklist before merging: