Use system git instead of libgit2
#777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbacquey
force-pushed
the
nb/replace_git
branch
2 times, most recently
from
f5b77b4 to
15ff8ed
Compare
nbacquey
force-pushed
the
nb/replace_git
branch
from
15ff8ed to
37d6294
Compare
Xophmeister
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR replaces the Git version we use from
libgit2to the system's version. This removes the dependency from OpenSSL, which caused errors when trying to build on arm64/MacOS.It also solves an error when trying to build grammars from private repositories.
Incidentally, I discovered when making this PR that the previous version did not properly checkout the pinned revision on grammars in
language.ncl: thegrammars/ocamldirectory did not exist in the revision we pin, but it does exist onmainCloses #776
Checklist
Checklist before merging: