Remove indentations and newlines in final-argument continuations #723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Although the PR solves the specific use-case of the issue, and leaves the rest of the test file (almost) intact, the tweak to the rule feels a bit artificial, and probably won't scale if we have similar cases in the future. |
Xophmeister
approved these changes
Sep 4, 2024
There was a problem hiding this comment.
I think this is good and, regarding:
the tweak to the rule feels a bit artificial, and probably won't scale if we have similar cases in the future.
...I'd go with a "cross that bridge when we come to it" argument 🙂
Maybe it's worth adding a comment somewhere relevant in ocaml.scm that links back to this PR and/or the issue so, if similar things do come up in the future, the context/solution can be quickly (re)established.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR tweaks the OCaml formatting rules around the concatenation operators (e.g.
@@) and anonymous function definitions, such that it is possible to write final-argument continuations without unnecessary indentations or newlines.Closes #718
Checklist
Checklist before merging: