fix: missing space for pattern matching of constructor holding record #720
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xophmeister
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
This LGTM -- thank you, @jonsterling 🙏
I'm not an expert on the OCaml formatting rules, though. It's worth waiting for @nbacquey's opinion.
|
No, it's not worth waiting I think. The PR looks great and very minimal. Can always revert if @nbacquey decides it's wrong. |
|
This looks perfect to me! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: missing space for pattern matching of constructor holding record
Issue: #719
Description
This fixes the formatting of pattern matching of constructors with an inline record pattern, which previously was missing a space.
Checklist
Checklist before merging: