Dynamic loading of grammars #716
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is interesting. Any chance this might be provisionally usable at the moment? |
It works on Linux right now (including NixOS), but I've only really tested the happy paths. So be careful! |
ErinvanderVeen
force-pushed
the
4-dynamic-loading-of-language-support
branch
4 times, most recently
from
3f55258 to
c131ff5
Compare
|
Passing! Hooray! : ) Nice work. |
ErinvanderVeen
force-pushed
the
4-dynamic-loading-of-language-support
branch
2 times, most recently
from
32d8d72 to
b806a53
Compare
ErinvanderVeen
changed the title
ErinvanderVeen
force-pushed
the
4-dynamic-loading-of-language-support
branch
4 times, most recently
from
6885233 to
8d9ea3f
Compare
Xophmeister
approved these changes
Aug 27, 2024
Xophmeister
reviewed
Aug 27, 2024
added 12 commits
September 10, 2024 16:52
This resolves lint error on #[wasm_bindgen]
added 6 commits
September 10, 2024 16:52
ErinvanderVeen
force-pushed
the
4-dynamic-loading-of-language-support
branch
from
487b142 to
925533f
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dynamic loading
Issue: #4
Description
The goal of this PR is to remove our dependencies on the tree-sitter grammar crates, and fetch and compile the grammars as necessary. Ideally, Topiary should not know about any language at all, and fetch all information from the configuration file.
Checklist
Checklist before merging: