Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toml: don't clobber quoted_key elements #623

Merged
merged 1 commit into from
Sep 9, 2023
Merged

toml: don't clobber quoted_key elements #623

merged 1 commit into from
Sep 9, 2023

Conversation

pjjw
Copy link
Contributor

@pjjw pjjw commented Sep 9, 2023

fixes #621

@pjjw
toml: don't clobber quoted_key elements
8fea221 
added some additional toml structures to the tests to ensure these cases
get tested.

fixes tweag#621
@ErinvanderVeen
Copy link
Collaborator

Thank you for the contribution!

@ErinvanderVeen ErinvanderVeen merged commit fe6083d into tweag:main Sep 9, 2023
@pjjw
Copy link
Contributor Author

pjjw commented Sep 9, 2023

thanks! i've got a follow-on grammar change while i was learning how to do tree-sitter queries to prevent some comment reordering weirdness in multiline arrays with the current rules, too, but that's maybe more subjective.

@ErinvanderVeen
Copy link
Collaborator

I would love to see what you have! I can't promise we will merge subjective changes, but it would be nice to see regardless.

In general, if your changes more accurately reflect the typical style used in toml files than the current queries, they will be merged.

@pjjw pjjw mentioned this pull request Sep 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ErinvanderVeen ErinvanderVeen ErinvanderVeen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Topiary deletes quoted strings in TOML tables
2 participants
@pjjw @ErinvanderVeen