Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Changes Sub-PR: Formatting subcommand #599

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

Xophmeister
Copy link
Member

This forms a part of PR #583 and must not be merged into main alone. It is only the implementation of isolated functionality -- and thus not expected to necessarily pass the CI checks -- to split up the work into logical chunks.

@Xophmeister Xophmeister mentioned this pull request Aug 18, 2023
26 tasks
@Xophmeister Xophmeister marked this pull request as ready for review August 23, 2023 12:08
@Xophmeister
Copy link
Member Author

Xophmeister commented Aug 23, 2023

@ErinvanderVeen It turns out that cache was working, but the locking is suboptimal. I've so far been unable to fix it, so I've just left it in there, with a FIXME note. However, fixing the cache shouldn't change main.rs, so once this PR is merged into chris/cli-changes, you can rebase from that to prevent being blocked, while I work on the tests.

@Xophmeister Xophmeister merged commit 7bb02bc into chris/cli-changes Aug 24, 2023
@Xophmeister Xophmeister deleted the chris/new-cli/formatting branch August 24, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants