Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Nickel quoted_enum_tag formatting by considering it a leaf #552

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

ErinvanderVeen
Copy link
Collaborator

Mentioned in #547 but doesn't resolve all of it.

From #547:

When parsing a quoted_enum_tag, tree-sitter-nickel defers to its scanner. The scanner produces a quoted_enum_tag_start, which is taken by Topiary and produced correctly. The parser then produces a chunk_literal_single containing only the contents of the following string. I.e. the last quote ending the string is completely dropped by tree-sitter-nickel.

@ErinvanderVeen ErinvanderVeen requested a review from torhovland July 3, 2023 11:25
@ErinvanderVeen ErinvanderVeen self-assigned this Jul 3, 2023
@ErinvanderVeen ErinvanderVeen added the language: nickel Nickel formatting issues label Jul 3, 2023
@ErinvanderVeen ErinvanderVeen merged commit 95c1ce8 into main Jul 3, 2023
@ErinvanderVeen ErinvanderVeen deleted the erin/nickel-idempotency-quoted-enum-tag branch July 3, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language: nickel Nickel formatting issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants