Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow_blank_line_before is only relative to the input #701

Closed
Xophmeister opened this issue Apr 9, 2024 · 0 comments · Fixed by #704
Closed

allow_blank_line_before is only relative to the input #701

Xophmeister opened this issue Apr 9, 2024 · 0 comments · Fixed by #704
Labels
epic: contributability Relates to how easy it is for external contributors to contribute to Topiary (engine and queries)

Comments

@Xophmeister
Copy link
Member

Xophmeister commented Apr 9, 2024

  1. There is no way to force newlines between items. You can allow newlines above something with allow_blank_line_before, but in some cases it could be useful to not only allow it but enforce it?

Originally posted by @lavigneer in #699

The allow_blank_line_before processing happens before formatting, on the input. If blank lines are subsequently inserted as part of formatting, then they will be squashed by the post-processor.

It would make sense for the post-processor to be sensitive to allow_blank_line_before nodes, so Topiary has a way of inserting horizontal whitespace between nodes.

@ErinvanderVeen ErinvanderVeen added the epic: contributability Relates to how easy it is for external contributors to contribute to Topiary (engine and queries) label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
epic: contributability Relates to how easy it is for external contributors to contribute to Topiary (engine and queries)
Projects
None yet
2 participants