fix: use slice patterns over iterator #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xophmeister
approved these changes
May 22, 2024
ErinvanderVeen
force-pushed
the
slice-patterns
branch
from
f441c42 to
abb01d4
Compare
ErinvanderVeen
force-pushed
the
slice-patterns
branch
from
abb01d4 to
2c07065
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slices for post_processing!
Description
This PR refactors our post_process_inner function to use slice pattern matching instead of the previous iterator based approach.
Motivation
Reason for this change it to make it easier to extend the match for patterns longer than just the first 2 atoms (which is something I wanted to do to fix #701).
Checklist
Checklist before merging: