Disable implicit nixpkgs config file #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*This is a breaking change*
By default, nixpkgs will read a global configuration file, by default
`~/.config/nixpkgs/config.nix`. This leads to reproducibility issues
if the configuration is different between users of the repository.
Users of `nixpkgs_packages` must set the `nix_file_deps` argument
with all the files used by the nix process.
We were previously accepting a global nixpkgs configuration file as
implicit dependency, but this commit now disallow that. User must
explicitly set its own nixpkgs configuration, such as:
```
import nixpkgs_path { config = {}; };
```
aherrmann
reviewed
Jun 3, 2019
|
@aherrmann Done, thank you. |
mboes
approved these changes
Jun 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change
By default, nixpkgs will read a global configuration file, by default
~/.config/nixpkgs/config.nix. This leads to reproducibility issuesif the configuration is different between users of the repository.
Users of
nixpkgs_packagesmust set thenix_file_depsargumentwith all the files used by the nix process.
We were previously accepting a global nixpkgs configuration file as
implicit dependency, but this commit now disallow that. User must
explicitly set its own nixpkgs configuration, such as: