toolchains/cc: Fix process getting killed on aarch64-darwin during li… #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nking
On aarch64 Darwin, when using a nixpkgs provided cc toolchain, we have [seen][1]
the linking step to fail as the process got killed:
```
bazel-out/darwin_arm64-opt-exec-2B5CBBC6/bin/external/rules_haskell/haskell/ghc_wrapper: line 80: 90734 Killed: 9
"${compile_flags[@]}" "${extra_args[@]}" 2>&1
90736 Done | drop_loaded_and_warning 1>&2
```
More specifically this happened when trying to add an rpath to a dylib calling the `install_name_tool`, but
running the same command manually succeeded.
This seems to be caused by mixing different tools from stdenv.cc and darwin.cctools, especially the fact that
the tools from the latter overwrote tools from the former.
Only add missing tools not provided by the current cc toolchain from the darwin.cctools package instead.
[1]: tweag/rules_haskell#2101
avdv
force-pushed
the
cb/fix-cc-toolchain-darwin-arm64
branch
from
5d4ee94 to
dba298e
Compare
benradf
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…nking
On aarch64 Darwin, when using a nixpkgs provided cc toolchain, we have seen the linking step to fail as the process got killed:
More specifically this happened when trying to add an rpath to a dylib calling the
install_name_tool, but running the same command manually succeeded.This seems to be caused by mixing different tools from stdenv.cc and darwin.cctools, especially the fact that the tools from the latter overwrote tools from the former.
Only add missing tools not provided by the current cc toolchain from the darwin.cctools package instead.