Release 0.10.0 #433
Merged
Release 0.10.0 #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to [the BCR instructions][bcr-test-module] a Bazel module can include a small, separate test module. This test module must be a sub-directory of the published BCR module. [bcr-test-module]: https://github.com/bazelbuild/bazel-central-registry/blob/main/docs/README.md#test-module
The `needs` field needs to reference the `jobs` item in the same workflow.
The automatic release notes did not include the tag annotation. Extract notes from the changelog instead.
benradf
reviewed
Oct 18, 2023
benradf
approved these changes
Oct 18, 2023
|
PR to add to BCR bazelbuild/bazel-central-registry#1022 |
prednaz
reviewed
Mar 28, 2024
| { | ||
| "integrity": "", | ||
| "strip_prefix": "{REPO}-{VERSION}/core", | ||
| "url": "https://github.com/{OWNER}/{REPO}/releases/download/{TAG}/${REPO}-${VERSION}.tar.gz" |
There was a problem hiding this comment.
why not use https://github.com/tweag/rules_nixpkgs/archive/refs/tags/v0.10.0.tar.gz which is available by default?
There was a problem hiding this comment.
The short version is that these automatically generated artifacts are not guaranteed to be bit-wise reproducible. But, Bazel uses sha256 to ensure that the downloaded artifact was not tampered with or otherwise damaged. So, any bit-change in the artifact would change the sha256 and cause a failure. So, instead, the recommendation is that Bazel rules produce dedicated release artifacts, which are guaranteed to stay the same.
See also the discussion here: bazel-contrib/SIG-rules-authors#11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates release 0.10.0.
The next steps are: