Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Rust and Foreign CC toolchains #178

Merged
merged 13 commits into from
Jan 24, 2022
Merged

Add Rust and Foreign CC toolchains #178

merged 13 commits into from
Jan 24, 2022

Conversation

itsadrake
Copy link
Contributor

No description provided.

@itsadrake itsadrake requested a review from aherrmann January 18, 2022 07:57
@itsadrake itsadrake self-assigned this Jan 18, 2022
aherrmann
aherrmann reviewed Jan 18, 2022
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good. I've added a couple comments.

examples/toolchains/rust/WORKSPACE Show resolved Hide resolved
examples/toolchains/rust/WORKSPACE Show resolved Hide resolved
examples/toolchains/rust/WORKSPACE Outdated Show resolved Hide resolved
nixpkgs/toolchains/rust.bzl Outdated Show resolved Hide resolved
nixpkgs/toolchains/rust.bzl Outdated Show resolved Hide resolved
nixpkgs/toolchains/rust.bzl Outdated Show resolved Hide resolved
nixpkgs/toolchains/rust.bzl Outdated Show resolved Hide resolved
nixpkgs/toolchains/rust.bzl Outdated Show resolved Hide resolved
nixpkgs/toolchains/rust.bzl Show resolved Hide resolved
nixpkgs/toolchains/foreign_cc.bzl Outdated Show resolved Hide resolved
aherrmann
aherrmann approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, thank you!

nixpkgs/toolchains/rust.bzl Show resolved Hide resolved
@aherrmann aherrmann merged commit 74c40cf into master Jan 24, 2022
@aherrmann aherrmann deleted the rust_toolchain branch January 24, 2022 17:06
@aherrmann aherrmann mentioned this pull request Feb 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aherrmann aherrmann aherrmann approved these changes

Assignees

@itsadrake itsadrake

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@itsadrake @aherrmann