Refactor WORKSPACE file #1886
Merged
Refactor WORKSPACE file #1886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ylecornec
force-pushed
the
ylecornec/refactor_workspace
branch
from
f055069 to
c02358c
Compare
14 tasks
|
🎉 All dependencies have been resolved ! |
Set this option to false to not try to install stack. This is usefull with bzlmod where we cannot rely on native.existing_rule to figure out if stack was already set up.
Refactor WORKSPACE dependencies in preparation for bzlmod
ylecornec
force-pushed
the
ylecornec/refactor_workspace
branch
from
c02358c to
0c6435f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1884
This PR refactors the WORKSPACE file by declaring most external repositories definitions to
non_modules_deps_*.bzlfiles,so they can be used later with
bzlmodthrough module extensions (See here for an example inrules_nixpkgs).A
setup_stackoption was added tostack_snapshotto optionally disable the installation of stack. Without bzlmod we rely onnative.existing_ruleto detect whether the stack repo is already set up, but this method is not compatible with bzlmod (See here). This option should only be necessary until astack_snapshotmodule extension is implemented for bzlmod.Some more repository rules are updated with an extra
registerparameter to optionally disable the registration of toolchains, because trying to do so fails in bzlmod.