Handling of toolchain libraries in stack_snapshot #1685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aherrmann
approved these changes
Jan 19, 2022
WORKSPACE
Outdated
Comment on lines
598
to
608
| ( | ||
| stack_snapshot( | ||
| name = "stackage_asterius", | ||
| local_snapshot = "@rules_haskell//tests/asterius/stack_toolchain_libraries:snapshot.yaml", | ||
| packages = [ | ||
| "xhtml", | ||
| ], | ||
| stack_snapshot_json = "@rules_haskell//tests/asterius/stack_toolchain_libraries:snapshot.json", | ||
| toolchain_libraries = toolchain_libraries, | ||
| ) if is_linux else None | ||
| ) |
There was a problem hiding this comment.
I think the outer parenthesis are not strictly necessary.
Comment on lines
+14
to
+21
| drop-packages: | ||
| - Win32 |
There was a problem hiding this comment.
Maybe worth a comment as to why this is being dropped.
Comment on lines
+16
to
+23
| drop-packages: | ||
| - Win32 |
Comment on lines
+2
to
+10
| drop-packages: | ||
| - Win32 |
ylecornec
force-pushed
the
ylecornec/cabal_toolchain_libs
branch
from
1334139 to
49b91ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the hard coded list of toolchain libraries from the
bazel.bzlfile.If the stack_snapshot is to be used by ghc, we will rely on stack to decide the toolchain libraries.
With a different compiler such as asterius, this list of toolchain libraries is configurable through the new
toolchain_librariesattribute.About the call to stack
We consider libraries without a
locationfield in the result ofstack ls dependencies json --global-hint --externalto be part of the toolchain.This happens in two cases:
stack.yaml(considered as local)So there are two kinds of mismatch to fix:
stack.yamlfile.The
toolchain_librariesattributeIf this attribute is set, it must contain all of the toolchain libraries.
So that we can know that a library is not in the toolchain and have an error message telling the user it should be added a custom stack snapshot.
The WORKSPACE file
To avoid writing the list of toolchain libraries explicitely, the asterius toolchain writes this list to the
toolchain_libraries.bzlfile so that it can be imported in the WORKSPACE file.Since this is linux only and we cannot conditionally
loadthis file, thetoolchain_librariesworkspace rule will create a file with a defaultNonevalue.