Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node to PATH of asterius cabal actions #1643

Merged
merged 2 commits into from
Nov 26, 2021

Conversation

ylecornec
Copy link
Member

This PR adds node to the tools and PATH of asterius cabal actions.

This is necessary to support Template Haskell and annotations such as the one added in example,
but until now it was only done in the run_ghc case and not the cabal one.

  • There is now a path_for_cabal field next to the path_for_runghc field in the tools_config section of the haskell toolchain.
    path_for_cabal does not contain the posix tools, because these are not specific to asterius, and always added to cabal actions.
  • These fields are now lists of paths instead of a string, and the join_path_list function is used to join them.

@ylecornec ylecornec requested a review from aherrmann November 25, 2021 15:39
Copy link
Member

@aherrmann aherrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aherrmann aherrmann added the merge-queue merge on green CI label Nov 26, 2021
@mergify mergify bot merged commit 3cb03a7 into master Nov 26, 2021
@mergify mergify bot deleted the ylecornec/asterius_cabal_path branch November 26, 2021 10:57
@mergify mergify bot removed the merge-queue merge on green CI label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants