Test start script on MacOS CI #1509
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disables the corresponding warning
```
external/zlib.dev/gzlib.c:252:9: error: implicit declaration of function 'lseek' is invalid in C99 [-Werror,-Wimplicit-function-declaration]
LSEEK(state->fd, 0, SEEK_END); /* so gzoffset() is correct */
^
```
Older versions don't work on MacOS ``` building '/nix/store/iyr224fd0npizqh3mvckpxjdzc0qr45h-pytest-hook.drv'... building '/nix/store/q325bf3n7y33nszmsn9pgcnxbp3dpava-python3-3.7.3.drv'... unpacking sources unpacking source archive /nix/store/r5ik1sbafp0kr3a7prnaca1lmmqmb0b6-Python-3.7.3.tar.xz source root is Python-3.7.3 setting SOURCE_DATE_EPOCH to timestamp 1553547549 of file Python-3.7.3/Misc/NEWS patching sources applying patch /nix/store/gd8ycd6j3qhcq1qccaqz68zdq5l4c2wf-no-ldconfig.patch patching file Lib/ctypes/util.py applying patch /nix/store/ggk7z3dvydrkypxff7d7c6v1slvbriin-darwin-libutil.patch patching file Modules/posixmodule.c Hunk #1 succeeded at 5907 (offset 27 lines). applying patch /nix/store/9kwzs3pplms8sijf55sdryypzvic4x1s-python-3.x-distutils-C++.patch patching file Lib/_osx_support.py patching file Lib/distutils/cygwinccompiler.py patching file Lib/distutils/sysconfig.py Hunk #1 succeeded at 183 (offset 13 lines). Hunk #2 succeeded at 202 (offset 13 lines). Hunk #3 succeeded at 231 (offset 13 lines). patching file Lib/distutils/unixccompiler.py Hunk #3 FAILED at 183. 1 out of 3 hunks FAILED -- saving rejects to file Lib/distutils/unixccompiler.py.rej patching file Makefile.pre.in Hunk #1 succeeded at 615 (offset 31 lines). builder for '/nix/store/q325bf3n7y33nszmsn9pgcnxbp3dpava-python3-3.7.3.drv' failed with exit code 1 cannot build derivation '/nix/store/26rq8gd6dh6vzn9rzz56ljqdr1sq90wi-ghc-8.6.4.drv': 1 dependencies couldn't be built error: build of '/nix/store/26rq8gd6dh6vzn9rzz56ljqdr1sq90wi-ghc-8.6.4.drv' failed ```
facundominguez
approved these changes
Mar 12, 2021
|
Mergify:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1475
Fixes and re-enables the start script tests on both nixpkgs and bindist MacOS CI pipelines.
-Won-implicit-function-declarationtozlib.devin bindist mode. The warning causes build errors on MacOS due to-Werror.--use-nix#1475). Also updates the GHC version accordingly.