Call stack update once #1199
Merged
Call stack update once #1199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a workaround for concurrent execution of `stack update`. See #1085
aherrmann
force-pushed
the
stack-update
branch
from
dc48370 to
5e0d414
Compare
mboes
approved these changes
Dec 31, 2019
Ensures that `stack update` is always executed once before `stack unpack`.
skydoc does not support `doc` attributes to `repository_rule`.
aherrmann
force-pushed
the
stack-update
branch
from
5e0d414 to
644f7a8
Compare
|
Merging manually as mergify is not picking this up. |
This was referenced Apr 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1090
As suggested in #1090 (see #1085 (comment) for related discussion) this factors out the call to
stack updateinto a separate repository rule_stack_update. Every instance of_stack_snapshotdepends on the same instance of_stack_update, so thatstack updateis only called once.This removes the need to call
stack updateleniently within_stack_snapshotand the need to preinstallstackand runstack updatemanually on Windows CI.I have used Bazel's
--experimental_workspace_rules_log_fileto verify the following.stack updateis executed on every fetch.stack updateis run before calls tostackin_stack_snapshot._stack_snapshotis not invalidated by_stack_update.