This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
Fix "float unrepresentable in integer range" runtime error due to incorrect unsigned conversion #632
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #629. Thanks to @mikesol @InBetweenNames, we located a very old runtime bug. The symptom is a "float unrepresentable in integer range" runtime error, and the root cause is:
i64
in parameter/return types, the JavaScript functions need to be imported to usef64
, and a layer of wrapper functions will generate casts betweeni64
andf64
._hs_text_memcmp
), this will result in an error.In the longer term we should be using the linear memory to pass FFI paramters/results in a uniform manner, without worrying about precision losses or signedness issues. But this PR suffices to fix the error for now.