This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TerrorJack
suggested changes
Apr 22, 2020
gkaracha
force-pushed
the
wip-fix-issue-568
branch
from
April 23, 2020 07:57
daf9327
to
72a99b8
Compare
Preliminary results @TerrorJack, preliminary comparison between HEAD and master:
< total time = 0.24 secs (245 ticks @ 1000 us, 1 processor)
< total alloc = 130,608,824 bytes (excludes profiling overheads)
---
> total time = 0.24 secs (244 ticks @ 1000 us, 1 processor)
> total alloc = 132,291,880 bytes (excludes profiling overheads)
< total time = 48.00 secs (47998 ticks @ 1000 us, 1 processor)
< total alloc = 3,320,867,416 bytes (excludes profiling overheads)
---
> total time = 45.61 secs (45606 ticks @ 1000 us, 1 processor)
> total alloc = 3,320,989,152 bytes (excludes profiling overheads)
< total time = 32.17 secs (32166 ticks @ 1000 us, 1 processor)
< total alloc = 125,277,473,792 bytes (excludes profiling overheads)
---
> total time = 9.68 secs (9675 ticks @ 1000 us, 1 processor)
> total alloc = 111,164,588,648 bytes (excludes profiling overheads) |
gkaracha
force-pushed
the
wip-fix-issue-568
branch
from
April 24, 2020 13:16
52ff1b7
to
55ef8a7
Compare
@TerrorJack I think it's ready for review now 🙂 |
TerrorJack
suggested changes
Apr 24, 2020
TerrorJack
approved these changes
Apr 24, 2020
master vs HEAD gives: < total time = 0.25 secs (246 ticks @ 1000 us, 1 processor)
< total alloc = 130,610,000 bytes (excludes profiling overheads)
---
> total time = 0.28 secs (283 ticks @ 1000 us, 1 processor)
> total alloc = 132,159,648 bytes (excludes profiling overheads)
< total time = 45.99 secs (45991 ticks @ 1000 us, 1 processor)
< total alloc = 3,320,876,440 bytes (excludes profiling overheads)
---
> total time = 47.77 secs (47772 ticks @ 1000 us, 1 processor)
> total alloc = 3,321,019,664 bytes (excludes profiling overheads)
< total time = 32.59 secs (32585 ticks @ 1000 us, 1 processor)
< total alloc = 125,276,180,272 bytes (excludes profiling overheads)
---
> total time = 11.17 secs (11166 ticks @ 1000 us, 1 processor)
> total alloc = 111,162,737,872 bytes (excludes profiling overheads) I think this is good to go @TerrorJack! 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.