This repository has been archived by the owner on Nov 24, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 58
Ship a subset of Stackage LTS packages in the pre-built Docker image #355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsyl20
approved these changes
Dec 2, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to fail on CI, but otherwise LGTM
I need to snipe some packages out of the list, will merge once the image builds on CI :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR installs additional packages in the global pkgdb of the pre-built Docker image, so the packages can be used directly by
ahc-link
/ahc
. Changeset:master
branch restriction when building the image on CIcabal.config
file which is provided by the Stackage server, pinning exact versions for most packageslts.sh
build script to be invoked after booting when building the imageThe
lts.sh
file contains the list of packages to build. They are picked from the complete list of known-to-compile packages. The principle of picking packages here should be:For brevity of the build script we don't put every package name into the build command; the packages listed are relatively high up in the dependency graph, so to bring in a lot of other common packages.
We can still add more packages here imo, as long as the CI job runs fine. It doesn't impact the rest of the pipeline anyway.