Skip to content
This repository has been archived by the owner on Nov 24, 2022. It is now read-only.

Ship a subset of Stackage LTS packages in the pre-built Docker image #355

Merged
merged 25 commits into from
Dec 3, 2019

Conversation

TerrorJack
Copy link
Member

This PR installs additional packages in the global pkgdb of the pre-built Docker image, so the packages can be used directly by ahc-link/ahc. Changeset:

  • (Temporary) Remove the master branch restriction when building the image on CI
  • Checks in a cabal.config file which is provided by the Stackage server, pinning exact versions for most packages
  • Include a lts.sh build script to be invoked after booting when building the image

The lts.sh file contains the list of packages to build. They are picked from the complete list of known-to-compile packages. The principle of picking packages here should be:

  • Actively maintained and belong to recent stackage lts snapshots and
  • Not making the total compile time of the image on CI exceed memory or time limit

For brevity of the build script we don't put every package name into the build command; the packages listed are relatively high up in the dependency graph, so to bring in a lot of other common packages.

We can still add more packages here imo, as long as the CI job runs fine. It doesn't impact the rest of the pipeline anyway.

@TerrorJack TerrorJack added P2 major: an upcoming release type: feature request labels Nov 29, 2019
@TerrorJack TerrorJack requested a review from hsyl20 November 29, 2019 16:18
@TerrorJack TerrorJack self-assigned this Nov 29, 2019
Copy link
Collaborator

@hsyl20 hsyl20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems to fail on CI, but otherwise LGTM

@TerrorJack
Copy link
Member Author

It seems to fail on CI

I need to snipe some packages out of the list, will merge once the image builds on CI :)

@TerrorJack TerrorJack merged commit 8303131 into master Dec 3, 2019
@TerrorJack TerrorJack deleted the wip-asterius-platform branch December 3, 2019 13:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P2 major: an upcoming release type: feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants