Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes to CI and isort dependency #473

Merged
merged 3 commits into from
Feb 21, 2025
Merged

Fixes to CI and isort dependency #473

merged 3 commits into from
Feb 21, 2025

Conversation

jherland
Copy link
Member

Quick PR of somewhat urgent fixes related to our CI setup, Python v3.8 support, or both:

  • Fix GH Actions failing due to Poetry v2 dropping support for Python v3.8
  • Upgrade GH Actions action/cache helper to a supported version
  • Fix omission of Python 3.12 and 3.13 for the self_test check in CI
  • Fix Python v3.8 support breaks projects that require isort 6.0.0 #472 by stating that isort must be <v6 when we're on Python 3.8

@jherland jherland added this to the FawltyDeps 1.0 milestone Feb 20, 2025
@jherland jherland self-assigned this Feb 20, 2025
@jherland jherland force-pushed the jherland/ci-and-dep-fixes branch 2 times, most recently from 135229c to 42ed7fb Compare February 20, 2025 15:47
@jherland
Copy link
Member Author

I've dropped the last part of this PR, re. isort upgrade, so that we can rather get the non-controversial parts merged quickly.

obscurerichard
obscurerichard approved these changes Feb 20, 2025
View reviewed changes
Copy link
Contributor

@obscurerichard obscurerichard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻 :shipit:

@jherland jherland merged commit 65a54ec into main Feb 21, 2025
67 checks passed
@jherland jherland deleted the jherland/ci-and-dep-fixes branch February 21, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obscurerichard obscurerichard obscurerichard approved these changes

@mknorps mknorps Awaiting requested review from mknorps

@zz1874 zz1874 Awaiting requested review from zz1874

Assignees

@jherland jherland

Labels
None yet
Projects
None yet
Milestone
FawltyDeps 1.0
Development

Successfully merging this pull request may close these issues.

Python v3.8 support breaks projects that require isort 6.0.0
2 participants
@jherland @obscurerichard