Work around issue in Pydantic v1.10.16 #439
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pydantic v1.10.16 introduces the `pydantic.v1` namespace (adopted from Pydantic v2) in order to make migrations from Pydantic v1 to v2 easier. However, as detailed in issue #438 (and the corresponding upstream issue pydantic/pydantic#9656), in Pydantic v1.10.16 (when run on Python 3.12) objects imported via the `pydantic.v1` namespace are not identical (in the `id(...)` sense) to the corresponding objects imported via the regular `pydantic` namespace. This causes problem when we want to catch exceptions raised by Pydantic: the actual exception class being raised is not identical to the one we `import` from `pydantic.v1.<something>`. The workaround applied here is to ensure that we never import from the `pydantic.v1` namespace when we're running on Pydantic v1.
I've run into a few cases where I've needed to recreate the Nox virtualenv, and I've simply deleted the corresponding reqs_from_poetry.txt file to ensure that everything is regenerated from scratch. However, the test in noxfile.py only checks for the associated .hash digest file, and then promptly fails when it tries to reuse the missing file. Add another clause to the if-condition to fix this.
|
There is an ongoing PR to fix the upstream issue: pydantic/pydantic#9660 If that ends up being merged and released soon, we can probably drop this PR. |
|
Pydantic v1.10.17 does not trigger the same issue, and this workaround is considered unnecessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor workaround to fix issue #438.
Upstream Pydantic issue: pydantic/pydantic#9656
Commits:
test_settings: Workaround issue in Pydantic v1.10.16noxfile.py: Rerunpoetry exportifreqs_from_poetry.txtis missing