Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Note About Changing to MIT #9994

Closed
wants to merge 5 commits into from
Closed

Add Note About Changing to MIT #9994

wants to merge 5 commits into from

Conversation

rhodrykorb
Copy link
Contributor

No description provided.

@@ -56,3 +56,7 @@ We only accept issues that are bug reports or feature requests. Bugs must be iso
## License

By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE

NOTE FOR VERSION 3.0.1: For v3.1 we will be changing the license from Apache to MIT and are in the process of getting approval of all commiteers of coder in the version 3.x code base.
By contributing your code, you agree to license your contirbution under the terms of the MIT License: https://github.com/twbs/bootstrap/blob/master/LICENSE
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo: contribution
And the link should point to /MIT, right? LICENSE is Apache.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@juthilo I have also contributed a MIT file, so the project contains the license. It was a suggestion that we include a copy of the license. I will fix the typo.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, that's what I meant. ...../MIT instead of ...../LICENSE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh - should have reread my code :)

I better fix that.

@@ -56,3 +56,7 @@ We only accept issues that are bug reports or feature requests. Bugs must be iso
## License

By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE

NOTE FOR VERSION 3.0.1: For v3.1 we will be changing the license from Apache to MIT and are in the process of getting approval of all commiteers of coder in the version 3.x code base.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some typos on this line - I would perhaps write:
and are in the process of collecting permissions to do so from all authors of Bootstrap code that is still in the current code base.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair call and I agree.
Was just using wording previously suggested.

@@ -56,3 +56,7 @@ We only accept issues that are bug reports or feature requests. Bugs must be iso
## License

By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE

NOTE FOR VERSION 3.0.1: For v3.1 we will be changing the license from Apache to MIT and are in the process of collecting permissions to do so from all authors of Bootstrap code that is still in the current code base.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any particular reason to mention 3.0.1 here.

@@ -138,4 +139,4 @@ For more information on SemVer, please visit [http://semver.org/](http://semver.

## Copyright and license

Copyright 2013 Twitter, Inc under [the Apache 2.0 license](LICENSE).
Copyright 2013 Twitter, Inc under [the Apache 2.0 license](LICENSE).

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add new line perhaps?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-Jog 2013 Twitter, Inc. az az Apache 2.0 licenc

@mdo
Copy link
Member

mdo commented Oct 5, 2013

For v3.1 we will be changing the license from Apache to MIT and are in the process of collecting permissions to do so from all authors of Bootstrap code that is still in the current code base.
For details please see issue #2054 at #2054

By contributing your code, you agree to dual-license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE and MIT License: https://github.com/twbs/bootstrap/blob/master/MIT

In the contributing file, let's use this instead. More succinct and, with shorter sentences, a bit easier to read (I hope).

With v3.1, we're moving from the Apache 2 to the MIT license for the Bootstrap code (not the docs). We're in the process of collecting permissions from all Bootstrap contributors with code still part of the project to make this happen. For details, please see [#2054](https://github.com/twbs/bootstrap/issues/2054).

By contributing your code, you agree to dual-license your contribution under [Apache 2](https://github.com/twbs/bootstrap/blob/master/LICENSE) and [MIT](https://github.com/twbs/bootstrap/blob/master/MIT) licenses.

Let's also rename MIT to LICENSE-MIT perhaps? Would help group the two things together more logically.

For the readme, instead of this:

For v3.1 we will be changing the license from Apache to MIT, please refer to CONTRIBUTING for more information.

Let's use this:

With v3.1, we're moving from the Apache 2 to the MIT license for the Bootstrap code (not the docs). Please see the [contributing guidelines](strap/blob/master/CONTRIBUTING.md) for more information.

Beyond that, one more point of clarification is needed I think. Are we relicensing, or dual licensing? We say we're changing or moving in many places, and in one we say we need it to be dual-licensed. Which is it? I have a feeling those differences could matter.

@juthilo
Copy link
Collaborator

juthilo commented Oct 15, 2013

Closing in favor of #11105

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants