-
-
Notifications
You must be signed in to change notification settings - Fork 79k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Note About Changing to MIT #9994
Conversation
@@ -56,3 +56,7 @@ We only accept issues that are bug reports or feature requests. Bugs must be iso | |||
## License | |||
|
|||
By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE | |||
|
|||
NOTE FOR VERSION 3.0.1: For v3.1 we will be changing the license from Apache to MIT and are in the process of getting approval of all commiteers of coder in the version 3.x code base. | |||
By contributing your code, you agree to license your contirbution under the terms of the MIT License: https://github.com/twbs/bootstrap/blob/master/LICENSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo: contribution
And the link should point to /MIT, right? LICENSE is Apache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@juthilo I have also contributed a MIT file, so the project contains the license. It was a suggestion that we include a copy of the license. I will fix the typo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's what I meant. ...../MIT instead of ...../LICENSE.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh - should have reread my code :)
I better fix that.
@@ -56,3 +56,7 @@ We only accept issues that are bug reports or feature requests. Bugs must be iso | |||
## License | |||
|
|||
By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE | |||
|
|||
NOTE FOR VERSION 3.0.1: For v3.1 we will be changing the license from Apache to MIT and are in the process of getting approval of all commiteers of coder in the version 3.x code base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some typos on this line - I would perhaps write:
and are in the process of collecting permissions to do so from all authors of Bootstrap code that is still in the current code base.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair call and I agree.
Was just using wording previously suggested.
@@ -56,3 +56,7 @@ We only accept issues that are bug reports or feature requests. Bugs must be iso | |||
## License | |||
|
|||
By contributing your code, you agree to license your contribution under the terms of the APLv2: https://github.com/twbs/bootstrap/blob/master/LICENSE | |||
|
|||
NOTE FOR VERSION 3.0.1: For v3.1 we will be changing the license from Apache to MIT and are in the process of collecting permissions to do so from all authors of Bootstrap code that is still in the current code base. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any particular reason to mention 3.0.1 here.
@@ -138,4 +139,4 @@ For more information on SemVer, please visit [http://semver.org/](http://semver. | |||
|
|||
## Copyright and license | |||
|
|||
Copyright 2013 Twitter, Inc under [the Apache 2.0 license](LICENSE). | |||
Copyright 2013 Twitter, Inc under [the Apache 2.0 license](LICENSE). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add new line perhaps?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-Jog 2013 Twitter, Inc. az az Apache 2.0 licenc
In the contributing file, let's use this instead. More succinct and, with shorter sentences, a bit easier to read (I hope).
Let's also rename MIT to LICENSE-MIT perhaps? Would help group the two things together more logically. For the readme, instead of this:
Let's use this:
Beyond that, one more point of clarification is needed I think. Are we relicensing, or dual licensing? We say we're changing or moving in many places, and in one we say we need it to be dual-licensed. Which is it? I have a feeling those differences could matter. |
Closing in favor of #11105 |
No description provided.