rename @screen-XX to @screen-XX-min for clarity+unambiguity #9963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this count as breaking backwards compatibility? |
|
Ah, good point. I can tweak it to preserve compatibility. |
|
@mdo OK, backward-compatibility fixed. |
mdo
added a commit
that referenced
this pull request
Aug 24, 2013
rename @screen-XX to @screen-XX-min for clarity+unambiguity
This was referenced Aug 24, 2013
Closed
mdo
added a commit
that referenced
this pull request
Aug 24, 2013
… update customizer as well; run grunt to adjust raw files
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Apr 11, 2014
rename @screen-XX to @screen-XX-min for clarity+unambiguity
stempler
pushed a commit
to stempler/bootstrap
that referenced
this pull request
Nov 4, 2014
rename @screen-XX to @screen-XX-min for clarity+unambiguity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@screen-XXis semi-implicitly the minimum size of an XX screen. This commit renames them to@screen-XX-minto avoid any confusion. Also makes for a nicer symmetry with the existing@screen-XX-maxvariables.Does not affect the generated CSS.
/to @mdo