Remove invalid .on() from bootstrap-dropdown.js #6970
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reported here but it's definitely not a functional use of |
|
Signed to #6835 issue and this pull-request |
|
This line also causes incompatibility with jQuery UI Dialog - dialogs can not be closed (using jquery 1.8.3 & jquery-ui 1.9.2) |
|
An alternative fix was applied: 40b7a90. |
|
Closing out. If there are any lingering issues, let us know with a new issue or PR against v3. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6835
Remnant from b5ad50686c (line 161) where first param was removed but not the whole line
For example, causes with aFarkas/webshim#211: IE8, IE9 and IE10 Release Preview for Windows 7